Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 3477001: Add pyauto hook for getting and manipulating the data underneath the NTP.... (Closed)

Created:
10 years, 3 months ago by kkania
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add pyauto hook for getting and manipulating the data underneath the NTP. BUG=49113 TEST=none

Patch Set 1 #

Total comments: 78

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+780 lines, -158 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 1 2 3 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 3 chunks +60 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 3 chunks +108 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 2 3 5 chunks +53 lines, -104 lines 0 comments Download
M chrome/browser/history/top_sites.h View 1 2 3 6 chunks +27 lines, -4 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 1 2 3 8 chunks +55 lines, -10 lines 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 3 20 chunks +98 lines, -40 lines 0 comments Download
A chrome/test/functional/ntp.py View 1 1 chunk +88 lines, -0 lines 0 comments Download
A chrome/test/pyautolib/ntp_model.py View 1 1 chunk +213 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kkania
10 years, 3 months ago (2010-09-20 22:57:44 UTC) #1
Nirnimesh
Thanks for putting this together. I've taken only a brief look so far. I'll get ...
10 years, 3 months ago (2010-09-21 01:52:18 UTC) #2
Paweł Hajdan Jr.
Drive-by. Definitely fix the issues Nirnimesh has pointed out, especially about the unneeded refcounting. http://codereview.chromium.org/3477001/diff/1/4 ...
10 years, 3 months ago (2010-09-21 08:51:20 UTC) #3
Nirnimesh
http://codereview.chromium.org/3477001/diff/1/2 File chrome/browser/automation/automation_provider_observers.cc (right): http://codereview.chromium.org/3477001/diff/1/2#newcode1326 chrome/browser/automation/automation_provider_observers.cc:1326: MessageLoop::current()->PostTask(FROM_HERE, We probably won't need this if we explicitly ...
10 years, 3 months ago (2010-09-21 20:09:35 UTC) #4
kkania
http://codereview.chromium.org/3477001/diff/1/2 File chrome/browser/automation/automation_provider_observers.cc (right): http://codereview.chromium.org/3477001/diff/1/2#newcode1299 chrome/browser/automation/automation_provider_observers.cc:1299: AutomationProvider* automation, IPC::Message* reply_message, On 2010/09/21 01:52:19, Nirnimesh wrote: ...
10 years, 3 months ago (2010-09-22 23:42:02 UTC) #5
sky
TopSites is currently disabled and I'm in the process of refactoring it. Could you hold ...
10 years, 3 months ago (2010-09-22 23:51:41 UTC) #6
kkania
10 years, 3 months ago (2010-09-23 00:15:42 UTC) #7
sure

Powered by Google App Engine
This is Rietveld 408576698