Printing: Push checking of |context| one level lower, as the different

Printing: Push checking of |context| one level lower, as the different
platforms have different expectations at this level.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60704

[Marc-Antoine Ruel (Google), 2010-09-25 01:40:12]

ok but it's just DCHECKs, they don't add value in the code. You could simply
have removed it and it would have been fine (and probably better in fact)

http://codereview.chromium.org/3475021/diff/1/3
File printing/printed_document_cairo.cc (right):

http://codereview.chromium.org/3475021/diff/1/3#newcode25
printing/printed_document_cairo.cc:25: DCHECK(context);
There's no implementation, there's no point in checking the value.

[James Hawkins, 2010-09-25 02:27:08]

On 2010/09/25 01:40:12, DO NOT USE!! wrote:
> ok but it's just DCHECKs, they don't add value in the code. You could simply
> have removed it and it would have been fine (and probably better in fact)
> 

I'm not sure I agree.  I'm in the process of refactoring much of this code, so
the DCHECKs both document my assumptions and alert me to bugs that may pop up in
the refactoring.

[James Hawkins, 2010-09-25 02:27:18]

http://codereview.chromium.org/3475021/diff/1/3
File printing/printed_document_cairo.cc (right):

http://codereview.chromium.org/3475021/diff/1/3#newcode25
printing/printed_document_cairo.cc:25: DCHECK(context);
On 2010/09/25 01:40:13, DO NOT USE!! wrote:
> There's no implementation, there's no point in checking the value.

I'm adding the implementation in a soon-to-be-uploaded CL, and I didn't want to
forget to add the DCHECK to the implementation.

[stuartmorgan, 2010-09-27 19:47:59]

LGTM

[M-A Ruel, 2010-09-27 19:51:25]

Oops, indeed lgtm. Sorry for the delay.