Issue 3474009: base_unittests: Turn down the sleeps on the stats table tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3474009: base_unittests: Turn down the sleeps on the stats table tests. (Closed)

Created:
10 years, 3 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

base_unittests: Turn down the sleeps on the stats table tests. These tests are over 20% of the time taken by base_unittests. I don't think making these sleeps shorter should affect their reliability too much. BUG=10611 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60385

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	base/stats_table_unittest.cc	View		4 chunks	+23 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

PS: I can't reproduce the flakiness mentioned in the bug, so I'm considering marking them ...

10 years, 3 months ago (2010-09-23 23:45:50 UTC) #1

lgtm

Expand Messages | Collapse Messages