Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 3474006: NTP: Don't show any sections or layout until we receive mv and apps. (Closed)

Created:
10 years, 3 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

NTP: Don't show any sections or layout until we receive mv and apps data. This improves performance and avoids flickeryness. BUG=56278 TEST=Install some apps and refresh the ntp over and over. Should not see flickering as mv section, then apps load. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M chrome/browser/resources/new_new_tab.css View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/resources/ntp/apps.js View 2 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
10 years, 3 months ago (2010-09-22 22:21:54 UTC) #1
arv (Not doing code reviews)
10 years, 3 months ago (2010-09-22 22:47:44 UTC) #2
LGTM

Death to flickeryness!

Powered by Google App Engine
This is Rietveld 408576698