crosutils: Make run_remote_tests' output for ambiguous case more clear.

crosutils: Make run_remote_tests' output for ambiguous case more clear.

BUG=5817
TEST=run_remote_tests --remote=$IP control shows ^...$ on all lines.

Change-Id: Ie0c4ac16493dc97044ec0bd0fd6d6e53a69c9041

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=aa5504f

[hughd, 2010-09-23 22:49:16]

LGTM - thanks.  (Though I'd have preferred suite_Nightly/control.browsertest to
be renamed - but I dare say you know of other such instances, so prefer to ask
us to input this way.)

[Luigi Semenzato, 2010-09-23 23:15:58]

Flyby review:

I also have been burned by this, and if you are going to touch it at all, I
would clean it up some more, just as a personal preference.  For instance, make
the search mechanism give a preference to "control" only over "control.*", and
signal ambiguity only if all files are in the form "control.*".  Then you don't
have to worry about ^...$.

On 2010/09/23 22:49:16, hughd wrote:
> LGTM - thanks.  (Though I'd have preferred suite_Nightly/control.browsertest
to
> be renamed - but I dare say you know of other such instances, so prefer to ask
> us to input this way.)

[kmixter1, 2010-09-24 00:11:51]

From off-thread discussion: seems like this might also lead to some
confusion when you have a situation like:
client/site_test/hardware_TPMFoo/control.a
client/site_test/hardware_TPMBar/control

and passing TPM acts as if you meant hardware_TPMBar/control.

Were I doing this again, I'd just add bash completion and treat the
arguments as a list of suffixes to
autotest/{client,server}/{tests,site_tests}/.  I'm not sure if others
(besides myself) are using the current unique substring functionality.

Pushing change with better description of what you're passing as a pattern.

On Thu, Sep 23, 2010 at 4:15 PM, <semenzato@chromium.org> wrote:

> Flyby review:
>
> I also have been burned by this, and if you are going to touch it at all, I
> would clean it up some more, just as a personal preference.  For instance,
> make
> the search mechanism give a preference to "control" only over "control.*",
> and
> signal ambiguity only if all files are in the form "control.*".  Then you
> don't
> have to worry about ^...$.
>
>
> On 2010/09/23 22:49:16, hughd wrote:
>
>> LGTM - thanks.  (Though I'd have preferred
>> suite_Nightly/control.browsertest
>>
> to
>
>> be renamed - but I dare say you know of other such instances, so prefer to
>> ask
>> us to input this way.)
>>
>
>
>
> http://codereview.chromium.org/3473015/show
>