client/site_tests/factory_WriteGBB/factory_WriteGBB.py - Issue 3473008: Prevent uninitialized variable in factory_WriteGBB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/site_tests/factory_WriteGBB/factory_WriteGBB.py

Issue 3473008: Prevent uninitialized variable in factory_WriteGBB (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/autotest.git

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/site_tests/factory_WriteGBB/factory_WriteGBB.py

diff --git a/client/site_tests/factory_WriteGBB/factory_WriteGBB.py b/client/site_tests/factory_WriteGBB/factory_WriteGBB.py

index 73542536674039df2d60d8af18401dd582d31233..4648592ad037416291c9d6fc6501211b8069c693 100644

--- a/client/site_tests/factory_WriteGBB/factory_WriteGBB.py

+++ b/client/site_tests/factory_WriteGBB/factory_WriteGBB.py

@@ -21,6 +21,10 @@ class factory_WriteGBB(test.test):

if 'part_id_hwqual' in shared_dict:

id = shared_dict['part_id_hwqual'].replace(' ', '_')

component_file = 'data_*/components_%s' % id

+ else:

+ raise error.TestError(

+ 'You need to run this test from factory UI, and have ' +

+ 'successfully completed the HWQual-ID matching test ')

component_files = glob.glob(component_file)

if len(component_files) != 1:

« no previous file with comments | « no previous file | no next file » | no next file with comments »