Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 3473008: Prevent uninitialized variable in factory_WriteGBB (Closed)

Created:
10 years, 3 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Tom Wai-Hong Tam
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Prevent uninitialized variable in factory_WriteGBB In order to prevent running the write GBB test without proper pre-requisition, test and provide error messages when the component file pattern cannot be found. BUG=chrome-os-partner:969 TEST=manually test with command line, should give error messages without unhandled exception. Change-Id: Ib3ae4261dccc78e61e76967c3fcd6ef21f8e079f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M client/site_tests/factory_WriteGBB/factory_WriteGBB.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hung-Te
10 years, 3 months ago (2010-09-21 05:00:08 UTC) #1
Tom Wai-Hong Tam
10 years, 3 months ago (2010-09-21 05:18:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698