Refactor SocketStream to report error to the delegate.

Refactor SocketStream to report error to the delegate.

error status will be reported to the delegate (e.g. websocket experiment task)
Finish() should be called at most once when STATE_CLOSE to STATE_NONE.

BUG=none
TEST=net_unittests didn't crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30560

[Yuzo, 2009-10-30 03:37:47]

http://codereview.chromium.org/347026/diff/1/2
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/347026/diff/1/2#newcode198
Line 198: if (delegate) {
delegate can be null if DetachDelegate() is called before Finish().
Should Release() be called also in that case?

[ukai, 2009-10-30 04:14:28]

Thanks for review.

I added STATE_CLOSE for closing state and call Finish() at STATE_CLOSE to
STATE_NONE.

http://codereview.chromium.org/347026/diff/1/2
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/347026/diff/1/2#newcode198
Line 198: if (delegate) {
On 2009/10/30 03:37:47, Yuzo wrote:
> delegate can be null if DetachDelegate() is called before Finish().
> Should Release() be called also in that case? 

Good catch. Thanks!

[tyoshino (SeeGerritForStatus), 2009-10-30 04:26:23]

LGTM

[Yuzo, 2009-10-30 04:43:51]

LGTM