Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: chrome/browser/cocoa/location_bar_view_mac.mm

Issue 347016: Implement page action popups. (Closed)
Patch Set: fixed failing test Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/cocoa/location_bar_view_mac.h" 5 #import "chrome/browser/cocoa/location_bar_view_mac.h"
6 6
7 #include "app/l10n_util_mac.h" 7 #include "app/l10n_util_mac.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/sys_string_conversions.h" 10 #include "base/sys_string_conversions.h"
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 int LocationBarViewMac::PageActionCount() { 288 int LocationBarViewMac::PageActionCount() {
289 NOTIMPLEMENTED(); 289 NOTIMPLEMENTED();
290 return -1; 290 return -1;
291 } 291 }
292 292
293 int LocationBarViewMac::PageActionVisibleCount() { 293 int LocationBarViewMac::PageActionVisibleCount() {
294 NOTIMPLEMENTED(); 294 NOTIMPLEMENTED();
295 return -1; 295 return -1;
296 } 296 }
297 297
298 ExtensionAction* LocationBarViewMac::GetPageAction(size_t index) {
299 NOTIMPLEMENTED();
300 return NULL;
301 }
302
303 ExtensionAction* LocationBarViewMac::GetVisiblePageAction(size_t index) {
304 NOTIMPLEMENTED();
305 return NULL;
306 }
307
308 void LocationBarViewMac::TestPageActionPressed(size_t index) {
309 NOTIMPLEMENTED();
310 }
311
298 NSImage* LocationBarViewMac::GetTabButtonImage() { 312 NSImage* LocationBarViewMac::GetTabButtonImage() {
299 if (!tab_button_image_) { 313 if (!tab_button_image_) {
300 SkBitmap* skiaBitmap = ResourceBundle::GetSharedInstance(). 314 SkBitmap* skiaBitmap = ResourceBundle::GetSharedInstance().
301 GetBitmapNamed(IDR_LOCATION_BAR_KEYWORD_HINT_TAB); 315 GetBitmapNamed(IDR_LOCATION_BAR_KEYWORD_HINT_TAB);
302 if (skiaBitmap) { 316 if (skiaBitmap) {
303 tab_button_image_.reset([gfx::SkBitmapToNSImage(*skiaBitmap) retain]); 317 tab_button_image_.reset([gfx::SkBitmapToNSImage(*skiaBitmap) retain]);
304 } 318 }
305 } 319 }
306 return tab_button_image_; 320 return tab_button_image_;
307 } 321 }
(...skipping 28 matching lines...) Expand all
336 break; 350 break;
337 case ToolbarModel::NO_ICON: 351 case ToolbarModel::NO_ICON:
338 [cell setHintIcon:nil label:nil color:nil]; 352 [cell setHintIcon:nil label:nil color:nil];
339 break; 353 break;
340 default: 354 default:
341 NOTREACHED(); 355 NOTREACHED();
342 break; 356 break;
343 } 357 }
344 [field_ resetFieldEditorFrameIfNeeded]; 358 [field_ resetFieldEditorFrameIfNeeded];
345 } 359 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/location_bar_view_mac.h ('k') | chrome/browser/extensions/page_action_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698