Issue 347008: Fix checkbins.py to find pefile import instead of .bat/.sh wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347008: Fix checkbins.py to find pefile import instead of .bat/.sh wrappers. (Closed)

Created:
11 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix checkbins.py to find pefile import instead of .bat/.sh wrappers. BUG=25952 TEST=still executes regardless of where you run the script from

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -7 lines)			Patch
M	tools/checkbins/checkbins.bat	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tools/checkbins/checkbins.py	View	1 chunk	+3 lines, -0 lines	1 comment	Download
	tools/checkbins/checkbins.sh	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 1 month ago (2009-10-28 19:55:43 UTC) #2

The upload failed but I assume you can just delete checkbins.sh.

lgtm

http://codereview.chromium.org/347008/diff/1/3
File tools/checkbins/checkbins.py (right):

http://codereview.chromium.org/347008/diff/1/3#newcode18
Line 18: sys.path.append(os.path.join(os.path.dirname(sys.argv[0]), '..', '..',
Use __file__ instead of sys.argv[0]

Expand Messages | Collapse Messages