Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 347002: Derive string size constants... (Closed)

Created:
11 years, 1 month ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Derive string size constants * The maximum length of short and medium sized strings is now derived from other constants. * Remove the redundant String part of their names. Committed: http://code.google.com/p/v8/source/detail?r=3162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -35 lines) Patch
M src/heap.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M src/objects.h View 2 chunks +8 lines, -6 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 5 chunks +9 lines, -9 lines 0 comments Download
M src/string-stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 1 month ago (2009-10-28 12:38:37 UTC) #1
Erik Corry
11 years, 1 month ago (2009-10-28 13:08:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698