Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 3468009: cros_workon: only touch local_manifest for minilayout users (Closed)

Created:
10 years, 3 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sosa
Visibility:
Public.

Description

cros_workon: only touch local_manifest for minilayout users Otherwise, you'll duplicate an entry already in the developers manifest and cause repo to get confused. BUG=6898 TEST=Verified that local_manifest gets updated when using minilayout.xml Verified that the local_manifset does not get updated when not. Change-Id: I67ffc7004a2267d0d5aaa31570ac2bbeaa8f4f96 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fd76ba6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M cros_workon View 1 chunk +6 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
10 years, 3 months ago (2010-09-21 18:59:56 UTC) #1
anush
10 years, 3 months ago (2010-09-21 19:04:28 UTC) #2
LGTM
On 2010/09/21 18:59:56, Mandeep Singh Baines wrote:
>

Powered by Google App Engine
This is Rietveld 408576698