Issue 3467009: [binutils] Prevent ld from rewriting tls access sequences with calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3467009: [binutils] Prevent ld from rewriting tls access sequences with calls (Closed)

Created:
10 years, 3 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
khim, Mark Seaborn, pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@gitrw.chromium.org:9222/nacl-toolchain.git

Visibility:
Public.

Description

[binutils] Prevent ld from rewriting tls access sequences with calls NaCl assembler inserts nops in front of a call for proper bundling. When linker tries to rewrite a code sequence that consists of something followed by a call, it complains about these nops. At the moment, simply disable rewriting these sequences. BUG=http://code.google.com/p/nativeclient/issues/detail?id=237 TEST=

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	binutils/bfd/elf32-i386.c	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	binutils/bfd/elf64-x86-64.c	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

10 years, 3 months ago (2010-09-23 14:28:10 UTC) #4

It's good to see that the binutils TLS code has got simpler since I looked at
this last year.  The changes I did were:
http://repo.or.cz/w/nacl-binutils.git/commit/ba2e8b1cc17f361cf04040eeb37749c2...
http://repo.or.cz/w/nacl-binutils.git/commit/64abae7eed86ba85081eeec454cc1f5b...

Mark

Expand Messages | Collapse Messages