Issue 3466017: install: fix shell redirections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3466017: install: fix shell redirections (Closed)

Created:
10 years, 3 months ago by adlr

Modified:
9 years ago

Reviewers:
Kenneth Waters

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/installer.git

Visibility:
Public.

Description

install: fix shell redirections "> file 2>&1" redirects both stderr/stdout to file, whereas "2>&1 > file" directs stderr to the old stdout and stdout to file. BUG=None TEST=shell tests on device Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a903e9e

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	chromeos-postinst	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos-recovery	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos-setimage	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kliegs

Why not just use &> or &>> instead? On Thu, Sep 23, 2010 at 6:05 ...

10 years, 3 months ago (2010-09-23 22:10:19 UTC) #3

Kenneth Waters

On 2010/09/23 22:10:19, kliegs wrote: > Why not just use &> or &>> instead? They're ...

10 years, 3 months ago (2010-09-23 22:12:18 UTC) #4

kliegs

10 years, 3 months ago (2010-09-23 22:15:13 UTC) #5

Oops.  hate when I miss things like that.  Thanks.


On Thu, Sep 23, 2010 at 6:12 PM, <kwaters@chromium.org> wrote:

> On 2010/09/23 22:10:19, kliegs wrote:
>
>> Why not just use &> or &>> instead?
>>
>
> They're not in POSIX shell.
>
>
> http://codereview.chromium.org/3466017/show
>

Expand Messages | Collapse Messages