Issue 3466009: Prepare push to trunk. Now working on version 2.4.6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3466009: Prepare push to trunk. Now working on version 2.4.6. (Closed)

Created:
10 years, 3 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. Now working on version 2.4.6. Committed: http://code.google.com/p/v8/source/detail?r=5501

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+13 lines, -0 lines	2 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years, 3 months ago (2010-09-22 09:28:14 UTC) #2

LGTM with small fixes.

http://codereview.chromium.org/3466009/diff/1/2
File ChangeLog (right):

http://codereview.chromium.org/3466009/diff/1/2#newcode2
ChangeLog:2: Performance improvements on all platforms.
Blank line after version line.

Line about performance is usually last.

http://codereview.chromium.org/3466009/diff/1/2#newcode11
ChangeLog:11: Fixed a bug with profiling RegExp calls (issue crbug/55999).
prefix crbug with http://

Expand Messages | Collapse Messages