Issue 3466006: Fix crasher with autofill infobar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3466006: Fix crasher with autofill infobar. (Closed)

Created:
10 years, 3 months ago by Jay Civelli

Modified:
4 years, 2 months ago

Reviewers:
GeorgeY, James Hawkins

CC:
chromium-reviews, ben+cc_chromium.org, James Hawkins, dhollowa

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix crasher with autofill infobar. The "save credit card" information was deleted by the AutofillManager when the form is submitted but was still pointed to by the TabContents, causing a crasher when navigating. BUG=50428 TEST=See steps in 56238.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary band-aid fix #

Patch Set 3 : Added James suggested comments #

Patch Set 4 : Attempt at fixing a SSLUITest #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ssl/ssl_browser_tests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

10 years, 3 months ago (2010-09-21 16:57:45 UTC) #2

LGTM, thanks for the fix.

http://codereview.chromium.org/3466006/diff/1/3
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3466006/diff/1/3#newcode433
chrome/browser/autofill/autofill_manager.cc:433: // Did we get the credit card
info?
In this case, the 'the' should be left out. It implies that there is CC info and
for some reason we're not getting this info.  The question is more of, "Was
credit card info submitted?"

http://codereview.chromium.org/3466006/diff/1/4
File chrome/browser/autofill/autofill_manager.h (right):

http://codereview.chromium.org/3466006/diff/1/4#newcode210
chrome/browser/autofill/autofill_manager.h:210: AutoFillCCInfoBarDelegate*
cc_infobar_;
Can you comment that the infobar deletes itself when it closes?

Expand Messages | Collapse Messages