Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 3465002: Add Sentry power strip control and cryptohome/sync stress test (Closed)

Created:
10 years, 3 months ago by dtu
Modified:
9 years, 7 months ago
Reviewers:
fes
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org, krisr
Visibility:
Public.

Description

Add Sentry power strip control and cryptohome/sync stress test Change-Id: If0c450aef0fe722f7af5720026e5d511cff9b0b7 BUG=chromium-os:6993 TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8813504

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed straggler, split 'creds' into two parameters, added 'iter' parameter, moved some stuff. #

Patch Set 3 : Mistake: iterations is already an autotest parameter for run_tests() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -0 lines) Patch
A client/common_lib/power_strip.py View 1 chunk +41 lines, -0 lines 0 comments Download
A client/site_tests/platform_CryptohomeSyncStress/control View 1 1 chunk +17 lines, -0 lines 0 comments Download
A client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py View 1 1 chunk +27 lines, -0 lines 0 comments Download
A server/site_tests/platform_CryptohomeSyncStressServer/control View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A server/site_tests/platform_CryptohomeSyncStressServer/platform_CryptohomeSyncStressServer.py View 1 2 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dtu
10 years, 3 months ago (2010-09-17 18:29:31 UTC) #1
fes
Some nits below. http://codereview.chromium.org/3465002/diff/1/3 File client/site_tests/platform_CryptohomeSyncStress/control (right): http://codereview.chromium.org/3465002/diff/1/3#newcode8 client/site_tests/platform_CryptohomeSyncStress/control:8: power failure." This line seems to ...
10 years, 3 months ago (2010-09-17 23:10:18 UTC) #2
dtu
http://codereview.chromium.org/3465002/diff/1/3 File client/site_tests/platform_CryptohomeSyncStress/control (right): http://codereview.chromium.org/3465002/diff/1/3#newcode8 client/site_tests/platform_CryptohomeSyncStress/control:8: power failure." On 2010/09/17 23:10:19, fes wrote: > This ...
10 years, 3 months ago (2010-09-18 00:06:32 UTC) #3
dtu
Sorry, that last patch was a dud. I forgot that iterations is a built-in parameter ...
10 years, 3 months ago (2010-09-18 01:11:39 UTC) #4
fes
10 years, 3 months ago (2010-09-23 17:27:36 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698