Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 3464008: Add call to logging::InitLogging() during startup to write to stderr.

Created:
10 years, 3 months ago by thieule
Modified:
10 years, 3 months ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add call to logging::InitLogging() during startup to write to stderr. There's no need to write to a file since we only log messages for commandline parameter validations (ie. usage errors). BUG=6446 TEST=unit test Change-Id: I0e55d569534f953526a6b788dbc6b3e284ff8b4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M crash_reporter.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
thieule
10 years, 3 months ago (2010-09-21 18:45:35 UTC) #1
kmixter1
LGTM On Tue, Sep 21, 2010 at 11:45 AM, <thieule@chromium.org> wrote: > Reviewers: kmixter1, > ...
10 years, 3 months ago (2010-09-21 20:37:39 UTC) #2
kmixter1
10 years, 3 months ago (2010-09-21 20:38:11 UTC) #3
Actually, LGTM, but please run logging_UserCrash remote test as well.

On Tue, Sep 21, 2010 at 1:37 PM, Ken Mixter <kmixter@chromium.org> wrote:

> LGTM
>
>
> On Tue, Sep 21, 2010 at 11:45 AM, <thieule@chromium.org> wrote:
>
>> Reviewers: kmixter1,
>>
>> Description:
>> Add call to logging::InitLogging() during startup to write to stderr.
>> There's no need to write to a file since we only log messages for
>> commandline
>> parameter validations (ie. usage errors).
>>
>> BUG=6446
>>
>> TEST=unit test
>>
>> Change-Id: I0e55d569534f953526a6b788dbc6b3e284ff8b4f
>>
>> Please review this at http://codereview.chromium.org/3464008/show
>>
>> SVN Base: http://git.chromium.org/git/crash-reporter.git
>>
>> Affected files:
>>  M crash_reporter.cc
>>
>>
>> Index: crash_reporter.cc
>> diff --git a/crash_reporter.cc b/crash_reporter.cc
>> index
>>
37c62a6fbd30ffb65362a73f89f2e8df2489192b..ff99748b25a6c31e86e0c9da4d1796e23402e983
>> 100644
>> --- a/crash_reporter.cc
>> +++ b/crash_reporter.cc
>> @@ -143,6 +143,10 @@ int main(int argc, char *argv[]) {
>>   FilePath my_path(argv[0]);
>>   file_util::AbsolutePath(&my_path);
>>   s_metrics_lib.Init();
>> +  InitLogging(NULL,
>> +              LOG_ONLY_TO_SYSTEM_DEBUG_LOG,
>> +              DONT_LOCK_LOG_FILE,
>> +              DELETE_OLD_LOG_FILE);
>>   s_system_log.Initialize(my_path.BaseName().value().c_str());
>>   KernelCollector kernel_collector;
>>   kernel_collector.Initialize(CountKernelCrash,
>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698