Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 3461031: Only run the phishing classifier for http: urls. (Closed)

Created:
10 years, 2 months ago by Brian Ryner
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, chrome-anti-phishing_googlegroups.com
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Only run the phishing classifier for http: urls. Also, dial back the error logging a bit for cases that could come up in practice (for example, unqualified hostnames on a local network). BUG=none TEST=PhishingClassifierTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M chrome/renderer/safe_browsing/phishing_classifier.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Ryner
10 years, 2 months ago (2010-09-28 06:07:57 UTC) #1
lzheng
LGTM
10 years, 2 months ago (2010-09-28 17:48:03 UTC) #2
Brian Ryner
Garrett, were you ok with this change? On Tue, Sep 28, 2010 at 10:48 AM, ...
10 years, 2 months ago (2010-09-30 21:32:46 UTC) #3
gcasto (DO NOT USE)
10 years, 2 months ago (2010-09-30 22:30:40 UTC) #4
LGTM

On 2010/09/30 21:32:46, Brian Ryner wrote:
> Garrett, were you ok with this change?
> 
> On Tue, Sep 28, 2010 at 10:48 AM, <mailto:lzheng@chromium.org> wrote:
> 
> > LGTM
> >
> >
> > http://codereview.chromium.org/3461031/show
> >
> 
> 
> 
> -- 
> -Brian
>

Powered by Google App Engine
This is Rietveld 408576698