Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/cocoa/page_info_window_mac.mm

Issue 3461016: [Mac] Convert the page info window to a bubble. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Address nits Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/cocoa/page_info_bubble_controller_unittest.mm ('k') | chrome/browser/labs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/cocoa/page_info_window_mac.h" 5 #include "chrome/browser/cocoa/page_info_window_mac.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "base/scoped_cftyperef.h" 10 #include "base/scoped_cftyperef.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 namespace browser { 50 namespace browser {
51 51
52 void ShowPageInfo(gfx::NativeWindow parent, 52 void ShowPageInfo(gfx::NativeWindow parent,
53 Profile* profile, 53 Profile* profile,
54 const GURL& url, 54 const GURL& url,
55 const NavigationEntry::SSLStatus& ssl, 55 const NavigationEntry::SSLStatus& ssl,
56 bool show_history) { 56 bool show_history) {
57 PageInfoWindowMac::ShowPageInfo(parent, profile, url, ssl, show_history); 57 PageInfoWindowMac::ShowPageInfo(parent, profile, url, ssl, show_history);
58 } 58 }
59 59
60 void ShowPageInfoBubble(gfx::NativeWindow parent,
61 Profile* profile,
62 const GURL& url,
63 const NavigationEntry::SSLStatus& ssl,
64 bool show_history) {
65 NOTIMPLEMENTED();
66 }
67
68 } // namespace browser 60 } // namespace browser
69 61
70 PageInfoWindowMac::PageInfoWindowMac(PageInfoWindowController* controller, 62 PageInfoWindowMac::PageInfoWindowMac(PageInfoWindowController* controller,
71 Profile* profile, 63 Profile* profile,
72 const GURL& url, 64 const GURL& url,
73 const NavigationEntry::SSLStatus& ssl, 65 const NavigationEntry::SSLStatus& ssl,
74 bool show_history) 66 bool show_history)
75 : controller_(controller), 67 : controller_(controller),
76 model_(new PageInfoModel(profile, url, ssl, show_history, this)), 68 model_(new PageInfoModel(profile, url, ssl, show_history, this)),
77 cert_id_(ssl.cert_id()) { 69 cert_id_(ssl.cert_id()) {
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 [cert_button setEnabled:YES]; 243 [cert_button setEnabled:YES];
252 } 244 }
253 } 245 }
254 246
255 // Resize the window. Only animate if the window is visible, otherwise it 247 // Resize the window. Only animate if the window is visible, otherwise it
256 // could be "growing" while it's opening, looking awkward. 248 // could be "growing" while it's opening, looking awkward.
257 [[controller_ window] setFrame:window_frame 249 [[controller_ window] setFrame:window_frame
258 display:YES 250 display:YES
259 animate:[[controller_ window] isVisible]]; 251 animate:[[controller_ window] isVisible]];
260 } 252 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/page_info_bubble_controller_unittest.mm ('k') | chrome/browser/labs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698