chrome/browser/browser_uitest.cc - Issue 346045: Mark ShowModalDialogTest.BasicTest as FLAKY

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_uitest.cc

Issue 346045: Mark ShowModalDialogTest.BasicTest as FLAKY (Closed)

Patch Set: Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_uitest.cc

diff --git a/chrome/browser/browser_uitest.cc b/chrome/browser/browser_uitest.cc

index 7e03983ea4783e6970fb50d07819edaef4df9e55..0fd635296ec05e5269f7f3694a4e4ed4c7785f39 100644

--- a/chrome/browser/browser_uitest.cc

+++ b/chrome/browser/browser_uitest.cc

@@ -243,7 +243,8 @@ class ShowModalDialogTest : public UITest {

}

};

-TEST_F(ShowModalDialogTest, BasicTest) {

+// Flakiness returned. Re-opened crbug.com/17806

+TEST_F(ShowModalDialogTest, FLAKY_BasicTest) {

FilePath test_file(test_data_directory_);

test_file = test_file.AppendASCII("showmodaldialog.html");

« no previous file with comments | « no previous file | no next file » | no next file with comments »