Issue 346042: Add default implementations for WebViewClient and WebWidgetClient...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346042: Add default implementations for WebViewClient and WebWidgetClient... (Closed)

Created:
11 years, 1 month ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add default implementations for WebViewClient and WebWidgetClient methods. Once these interfaces live upstream, we'll want to allow the addition of new methods w/o requiring the consumer (chrome) to implement the new methods. That'll make webkit merging easier, and it'll also make it possible to use a newer webkit with an older chrome. Obviously, this only works if the methods are not crucial to webkit working properly, but that is generally the case for *Client methods. R=dglazkov BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30943

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -320 lines)			Patch
M	chrome/renderer/print_web_view_helper.h	View	1 chunk	+1 line, -113 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	webkit/api/public/WebViewClient.h	View	9 chunks	+54 lines, -57 lines	0 comments	Download
M	webkit/api/public/WebWidgetClient.h	View	1 chunk	+15 lines, -15 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	7 chunks	+0 lines, -55 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages