Support for function calls on an arbitrary expression that returns...

src/ia32/fast-codegen-ia32.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 770 matching lines @@
   __ CallStub(&stub);
   // Restore context register.
   __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
   // Discard the function left on TOS.
   DropAndMove(expr->context(), eax);
 }
 
 
 void FastCodeGenerator::VisitCall(Call* expr) {
   Expression* fun = expr->expression();
+  Variable* var = fun->AsVariableProxy()->AsVariable();
 
-  if (fun->AsProperty() != NULL) {
+  if (var != NULL &&
+      var->is_possibly_eval()) {
+    // Call to eval.
+    UNREACHABLE();
+  } else if (fun->AsProperty() != NULL) {
     // Call on a property.
     Property* prop = fun->AsProperty();
     Literal* key = prop->key()->AsLiteral();
     if (key != NULL && key->handle()->IsSymbol()) {
       // Call on a named property: foo.x(1,2,3)
       __ push(Immediate(key->handle()));
       Visit(prop->obj());
       // Use call IC.
       EmitCallWithIC(expr, RelocInfo::CODE_TARGET);
     } else {
@@ skipping 15 matching lines @@
       // Push result (function).
       __ push(eax);
       // Push receiver object on stack.
       if (prop->is_synthetic()) {
         __ push(CodeGenerator::GlobalObject());
       } else {
         __ push(ebx);
       }
       EmitCallWithStub(expr);
     }
-  } else if (fun->AsVariableProxy()->AsVariable() != NULL) {
+  } else if (var != NULL) {
     // Call on a global variable
-    Variable* var = fun->AsVariableProxy()->AsVariable();
-    ASSERT(var != NULL && !var->is_this() && var->is_global());
+    ASSERT(var != NULL);
+    ASSERT(!var->is_this());
+    ASSERT(var->is_global());
     ASSERT(!var->is_possibly_eval());
     __ push(Immediate(var->name()));
     // Push global object (receiver).
     __ push(CodeGenerator::GlobalObject());
     EmitCallWithIC(expr, RelocInfo::CODE_TARGET_CONTEXT);
+  } else if (var != NULL && var->slot() != NULL &&
+             var->slot()->type() == Slot::LOOKUP) {
+    // Call inside a with-statement
+    UNREACHABLE();
   } else {
-    // Calls we cannot handle right now.
-    // Should bailout in the CodeGenSelector.
-    UNREACHABLE();
+    // Call with an arbitrary function expression.
+    Visit(expr->expression());
+    // Load global receiver object.
+    __ mov(ebx, CodeGenerator::GlobalObject());
+    __ push(FieldOperand(ebx, GlobalObject::kGlobalReceiverOffset));
+    // Emit function call.
+    EmitCallWithStub(expr);
   }
 }
 
 void FastCodeGenerator::VisitCallNew(CallNew* expr) {
   Comment cmnt(masm_, "[ CallNew");
   // According to ECMA-262, section 11.2.2, page 44, the function
   // expression in new calls must be evaluated before the
   // arguments.
   // Push function on the stack.
   Visit(expr->expression());
@@ skipping 256 matching lines @@
     default:
       UNREACHABLE();
   }
 }
 
 
 #undef __
 
 
 } }  // namespace v8::internal