Issue 346026: Remove TemporaryGlue::popupsAllowed by just having the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346026: Remove TemporaryGlue::popupsAllowed by just having the... (Closed)

Created:
11 years, 1 month ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove TemporaryGlue::popupsAllowed by just having the corresponding ChromiumBridge method return false. It turns out that NPP is always null in Chrome (due to out-of-process plugins), and as a result, we were always returning false anyways. R=jam BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30632

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -18 lines)			Patch
M	webkit/api/src/ChromiumBridge.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/api/src/TemporaryGlue.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages