Issue 346019: Initialize the chrome thread object at the start of the CFUrlRequestUnittestR...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346019: Initialize the chrome thread object at the start of the CFUrlRequestUnittestR... (Closed)

Created:
11 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews_googlegroups.com, darin (slow to review), amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Initialize the chrome thread object at the start of the CFUrlRequestUnittestRunner constructor. This causes a CHECK to fire in the extensions service initialization which happens when we initialize the profile. The CHECK was added in revision 30550. Given the spate of these test failures we should really speed up the process of moving the chrome frame builder to the main waterfall. TBR=tommi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30556

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome_frame/test/net/fake_external_tab.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages