Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 346013: Remove tapuz.co.il from search provider list since it isn't a search provider. (Closed)

Created:
11 years, 1 month ago by jeremy
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, jungshik at Google
Visibility:
Public.

Description

Remove tapuz.co.il from search provider list since it isn't a search provider. This was added erroneously and has never worked, removing. BUG=7271 TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" , tapuz should not be displayed as a search provider.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bump data version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jeremy
11 years, 1 month ago (2009-10-29 12:30:00 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/346013/diff/1/2 File chrome/browser/search_engines/template_url_prepopulate_data.cc (right): http://codereview.chromium.org/346013/diff/1/2#newcode3205 Line 3205: return 24; // Increment this if you change ...
11 years, 1 month ago (2009-10-29 14:32:56 UTC) #2
jeremy
Data version bumped per-Avi's comment. http://codereview.chromium.org/346013/diff/1/2 File chrome/browser/search_engines/template_url_prepopulate_data.cc (right): http://codereview.chromium.org/346013/diff/1/2#newcode3205 Line 3205: return 24; // ...
11 years, 1 month ago (2009-10-29 15:07:10 UTC) #3
Avi (use Gerrit)
lg
11 years, 1 month ago (2009-10-29 15:09:13 UTC) #4
jeremy
Waiting on Peter's LG before checkin.
11 years, 1 month ago (2009-10-29 15:21:42 UTC) #5
Peter Kasting
This is fine, but don't check in yet; I need to make a fix to ...
11 years, 1 month ago (2009-10-29 17:13:23 UTC) #6
Peter Kasting
11 years, 1 month ago (2009-10-29 20:39:17 UTC) #7
OK, safe to checkin.  Please mention in the change description or on the bug
that this depends on r30508, in case we want to merge it back to anywhere.

Powered by Google App Engine
This is Rietveld 408576698