Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 3459004: Create implicit concept of iterations in wifitest (Closed)

Created:
10 years, 3 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Create implicit concept of iterations in wifitest We are losing a lot of data because steps don't know if they are repeated, and don't enter separate keyvals for each iteration. This CL addresses this by first assessing all repeated steps in a test and assigning iterators to each one of them. Then as the steps are being processed, provide a "prefix" variable that is prepended to each keyval. This has the handy side-effect of the step not needing to have to repeat its method name every time it writes out a variable. BUG=none TEST=run_remote_tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M server/site_wifitest.py View 12 chunks +32 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 3 months ago (2010-09-16 19:46:13 UTC) #1
Sam Leffler
10 years, 3 months ago (2010-09-16 22:45:33 UTC) #2
LGTM (nice)

Powered by Google App Engine
This is Rietveld 408576698