Issue 3455024: Notify all rosters on opening and closing chats,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3455024: Notify all rosters on opening and closing chats,... (Closed)

Created:
10 years, 3 months ago by seh

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Notify all rosters on opening and closing chats, so they can update visual status. TEST=Open iGoogle, Gmail and the central roster. Start a chat. Check status in all 3 rosters. BUG=chromium-os:1484 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60741

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -27 lines)			Patch
M	chrome/browser/resources/chat_manager/background.html	View		2 chunks	+20 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/chat_manager/js/chatbridgeeventtypes.js	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/resources/chat_manager/js/chatbridgehook.js	View		5 chunks	+27 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/chat_manager/js/gmailbridgehook.js	View	1	2 chunks	+16 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/chat_manager/manifest.json	View	2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM w/ one nit/suggestion http://codereview.chromium.org/3455024/diff/1/5 File chrome/browser/resources/chat_manager/js/gmailbridgehook.js (right): http://codereview.chromium.org/3455024/diff/1/5#newcode28 chrome/browser/resources/chat_manager/js/gmailbridgehook.js:28: * @param {string} eventType the ...

10 years, 2 months ago (2010-09-28 00:31:44 UTC) #2

seh

10 years, 2 months ago (2010-09-28 00:54:12 UTC) #3

http://codereview.chromium.org/3455024/diff/1/5
File chrome/browser/resources/chat_manager/js/gmailbridgehook.js (right):

http://codereview.chromium.org/3455024/diff/1/5#newcode28
chrome/browser/resources/chat_manager/js/gmailbridgehook.js:28: * @param
{string} eventType the event type.
On 2010/09/28 00:31:44, scherkus wrote:
> this seems to be duplicated from chatbridgehook.js
> 
> how about moving this code to a file like "common.js" ?

Agreed to add a TODO for now.

Expand Messages | Collapse Messages