Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 3455022: Revert 60378 (trying to track down http://crbug.com/56752 )- Flesh out URLLoa... (Closed)

Created:
10 years, 3 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
michaeln
CC:
chromium-reviews, cbentzel+watch_chromium.org, dpranke+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 60378 (trying to track down http://crbug.com/56752 )- Flesh out URLLoader's download_to_file function. * tie the lifetime of the resulting temp file to the lifetime of the URLLoader (the plan is to later extend the lifetime of the temp file to support xhr.responseBlob) * make it work in test_shell * make it work for sync requests * added OnDataDownloaded messages to report progress A related BlobURL loading change. * grab a reference to the blob early on to ensure it's still there when the 'job' is finally started. TEST=manual and deletable_file_reference_unittest.cc BUG=52486 Review URL: http://codereview.chromium.org/3165062 TBR=michaeln@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -464 lines) Patch
M chrome/browser/net/blob_url_request_job_factory.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/redirect_to_file_resource_handler.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/renderer_host/redirect_to_file_resource_handler.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 4 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 10 chunks +2 lines, -48 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_request_info.h View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/resource_handler.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/render_messages_internal.h View 4 chunks +12 lines, -15 lines 0 comments Download
M chrome/common/resource_dispatcher.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 9 chunks +75 lines, -74 lines 0 comments Download
D webkit/blob/deletable_file_reference.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/blob/deletable_file_reference.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D webkit/blob/deletable_file_reference_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M webkit/blob/webkit_blob.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 15 chunks +3 lines, -53 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
10 years, 3 months ago (2010-09-24 05:19:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698