Issue 3454035: Revert attempt to make heap size 32/64 clean. This change needs to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3454035: Revert attempt to make heap size 32/64 clean. This change needs to... (Closed)

Created:
10 years, 2 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert attempt to make heap size 32/64 clean. This change needs to be done from Windows where the compiler is stricter about truncating changes. Committed: http://code.google.com/p/v8/source/detail?r=5545

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -228 lines)			Patch
M	src/arm/simulator-arm.cc	View	5 chunks	+5 lines, -7 lines	0 comments	Download
M	src/assembler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/contexts.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/data-flow.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/disassembler.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/global-handles.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/heap.h	View	9 chunks	+18 lines, -18 lines	0 comments	Download
M	src/heap.cc	View	14 chunks	+36 lines, -56 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/objects-debug.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.cc	View	16 chunks	+23 lines, -34 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.h	View	19 chunks	+39 lines, -43 lines	0 comments	Download
M	src/spaces.cc	View	8 chunks	+10 lines, -17 lines	0 comments	Download
M	src/utils.h	View	1 chunk	+5 lines, -15 lines	0 comments	Download
M	test/mjsunit/binary-op-newspace.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/math-abs.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/math-floor.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rubberstamp LGTM

Expand Messages | Collapse Messages