autotest: Test new meta files in crash directory

autotest: Test new meta files in crash directory

Change-Id: I01f6dd829ba470934b27d0d9cc7756c0f2e6b1ed

BUG=6100, 5805, 5624, 6865
TEST=These tests pass

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=67ff562

[kmixter1, 2010-09-29 17:23:05]

UserCrash and CrashSender now pass, I'm still working on KernelCrash but thought
it would be good to get feedback on the first two.

[ericli, 2010-09-29 17:27:27]

Ken,

when you feel is ready, please advice how we should properly label our lab
devices.

On Wed, Sep 29, 2010 at 10:23 AM, <kmixter@chromium.org> wrote:

> Reviewers: petkov,
>
> Message:
> UserCrash and CrashSender now pass, I'm still working on KernelCrash but
> thought
> it would be good to get feedback on the first two.
>
> Description:
> autotest: Test new meta files in crash directory
>
> Change-Id: I01f6dd829ba470934b27d0d9cc7756c0f2e6b1ed
>
> BUG=6100,5805,5624,6865
> TEST=These tests pass
>
> Please review this at http://codereview.chromium.org/3454023/show
>
> SVN Base: http://git.chromium.org/git/autotest.git
>
> Affected files:
>  M client/bin/site_crash_test.py
>  M client/site_tests/logging_CrashSender/logging_CrashSender.py
>  M client/site_tests/logging_KernelCrash/logging_KernelCrash.py
>  M client/site_tests/logging_UserCrash/logging_UserCrash.py
>  M server/site_host_attributes.py
>  M server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

[kmixter1, 2010-09-29 17:56:12]

That's a separate change - to enable KernelCrashServer in the regression
suite.

We can do that one of two ways:
1) keep using the has_working_kcrash and label all dogfood devices with our
firmware this way
2) start using has_chromeos_firmware and make sure no non-dogfood devices
have this label

I'm OK with either.

On Wed, Sep 29, 2010 at 10:27 AM, Eric Li(李咏竹) <ericli@chromium.org> wrote:

> Ken,
>
> when you feel is ready, please advice how we should properly label our lab
> devices.
>
>
> On Wed, Sep 29, 2010 at 10:23 AM, <kmixter@chromium.org> wrote:
>
>> Reviewers: petkov,
>>
>> Message:
>> UserCrash and CrashSender now pass, I'm still working on KernelCrash but
>> thought
>> it would be good to get feedback on the first two.
>>
>> Description:
>> autotest: Test new meta files in crash directory
>>
>> Change-Id: I01f6dd829ba470934b27d0d9cc7756c0f2e6b1ed
>>
>> BUG=6100,5805,5624,6865
>> TEST=These tests pass
>>
>> Please review this at http://codereview.chromium.org/3454023/show
>>
>> SVN Base: http://git.chromium.org/git/autotest.git
>>
>> Affected files:
>>  M client/bin/site_crash_test.py
>>  M client/site_tests/logging_CrashSender/logging_CrashSender.py
>>  M client/site_tests/logging_KernelCrash/logging_KernelCrash.py
>>  M client/site_tests/logging_UserCrash/logging_UserCrash.py
>>  M server/site_host_attributes.py
>>  M
>> server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
>>
>>
>>
>
>
> --
> Eric Li
> 李咏竹
> Google Kirkland
>
>
>

[petkov, 2010-09-29 19:01:36]

LGTM

[kmixter1, 2010-09-30 01:49:43]

PTAL - fixed up logging_KernelCrash.

[petkov, 2010-09-30 05:29:27]

LGTM

http://codereview.chromium.org/3454023/diff/12001/6007
File server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
(right):

http://codereview.chromium.org/3454023/diff/12001/6007#newcode18
server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py:18:
"""Copy remote source to dest removing dest if source does not exist."""
I don't quite understand the comment -- you always remove dest regardless of the
existence of source, I think.