Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 3454022: Fix a c_str() use-after-free bug in the printing code. (Closed)

Created:
10 years, 3 months ago by ncarter (slow)
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins, jhawkins
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Fix a c_str() use-after-free bug in the printing code. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M printing/printing_context_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ncarter (slow)
Hi James, Please review -- happened across this when grepping the code.
10 years, 3 months ago (2010-09-22 21:24:48 UTC) #1
ncarter (slow)
ping
10 years, 3 months ago (2010-09-23 19:48:40 UTC) #2
ncarter (slow)
jhawkins ping
10 years, 3 months ago (2010-09-24 20:29:46 UTC) #3
James Hawkins
10 years, 3 months ago (2010-09-24 22:52:08 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698