Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 3454014: Add desktopui_ImeTest to the nightly control file. (Closed)

Created:
10 years, 3 months ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
ericli, ericli
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, petkov+cc_chromium.org, satorux1, ericli
Visibility:
Public.

Description

Add desktopui_ImeTest to the nightly control file. Change-Id: I25672d492d391d5fe8bd229b2b6e2bec62c19216 BUG=chromium-os:4639 TEST=Check that the test runs. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7814a55

Patch Set 1 #

Total comments: 2

Patch Set 2 : m comes after b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M server/site_tests/suite_Nightly/control View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Zachary Kuznia
10 years, 3 months ago (2010-09-22 01:48:13 UTC) #1
ericli
Please keep the test list in alphabetic order, otherwise LGTM. http://codereview.chromium.org/3454014/diff/1/2 File server/site_tests/suite_Nightly/control (right): http://codereview.chromium.org/3454014/diff/1/2#newcode25 ...
10 years, 3 months ago (2010-09-22 06:17:39 UTC) #2
Zachary Kuznia
10 years, 3 months ago (2010-09-22 06:54:34 UTC) #3
http://codereview.chromium.org/3454014/diff/1/2
File server/site_tests/suite_Nightly/control (right):

http://codereview.chromium.org/3454014/diff/1/2#newcode25
server/site_tests/suite_Nightly/control:25: ('desktopui_IBusTest', {}),
On 2010/09/22 06:17:40, ericli wrote:
> put ImeTest behind IBusTest.

Done.

Powered by Google App Engine
This is Rietveld 408576698