Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 3453025: Relanding this patch with the compile fix for Visual studio 2005. The compile... (Closed)

Created:
10 years, 3 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Relanding this patch with the compile fix for Visual studio 2005. The compiler gets confused between the two Delegate classes URLRequest::Delegate and the PluginDownloadHelper::Delegate class. Renaming the latter seems to work Fix a regression introduced in the chrome plugin installer on Windows in revision 54316 which was to remove usages of GetTempDir. However the change failed to take into account that the file name which is used to perform the download eventually is shell executed on windows. In this case the download was performed on a temporary file which causes ShellExecute to put up a confirmation dialog asking the user to select the application for opening the file. Fix is to rename the temp file path to the desired file path on success. Fixes bug http://code.google.com/p/chromium/issues/detail?id=56746 Bug=56746 Test=Covered by plugin installer plugin test. TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60577

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -215 lines) Patch
A chrome/browser/plugin_download_helper.h View 1 chunk +80 lines, -0 lines 0 comments Download
A chrome/browser/plugin_download_helper.cc View 1 chunk +190 lines, -0 lines 0 comments Download
M chrome/browser/plugin_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_process_host.cc View 4 chunks +4 lines, -198 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 4 chunks +135 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
10 years, 3 months ago (2010-09-25 09:19:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698