Issue 3453012: [gcc] x86_64 TLS support refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3453012: [gcc] x86_64 TLS support refactoring (Closed)

Created:
10 years, 3 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
khim, Mark Seaborn, pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@gitrw.chromium.org:9222/nacl-toolchain.git

Visibility:
Public.

Description

[gcc] x86_64 TLS support refactoring Enable all TLS access models. Replace misleading non-standard __tls_get_addr with newly introduced __nacl_read_tp. Standard __tls_get_addr is now used for dynamic TLS access models, as intended. BUG= TEST=

Patch Set 1 #

Patch Set 2 : ready for code review #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -36 lines)			Patch
M	gcc/gcc/config/i386/i386.c	View	4 chunks	+35 lines, -9 lines	0 comments	Download
M	gcc/gcc/config/i386/i386.md	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	gcc/gcc/varasm.c	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

khim

LGTM It's only x86-64 case, right? IA32 is still not fixed WRT to %ECX clobbering?

10 years, 3 months ago (2010-09-24 12:19:47 UTC) #2

eaeltsin

10 years, 3 months ago (2010-09-24 13:55:50 UTC) #3

Yes, it's for x86-64 only. ix86 will go in in a separate change.

> It's only x86-64 case, right? IA32 is still not fixed WRT to %ECX clobbering?

Expand Messages | Collapse Messages