Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: media/base/factory.h

Issue 3452030: FBTF: Moves code to the headers. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/buffers.cc ('k') | media/base/factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/factory.h
diff --git a/media/base/factory.h b/media/base/factory.h
index b9e637d26a3edbe2d04790943b60d8117736b442..d5dd9a72ad371e7b0390f8c61f44261ddaa66c2e 100644
--- a/media/base/factory.h
+++ b/media/base/factory.h
@@ -67,34 +67,25 @@ class FilterFactory : public base::RefCountedThreadSafe<FilterFactory> {
const MediaFormat& media_format) = 0;
friend class base::RefCountedThreadSafe<FilterFactory>;
- virtual ~FilterFactory() {}
+ FilterFactory();
+ virtual ~FilterFactory();
};
// Maintains a collection of FilterFactories.
class FilterFactoryCollection : public FilterFactory {
public:
- FilterFactoryCollection() {}
+ FilterFactoryCollection();
// Adds a factory to the end of the collection.
- void AddFactory(FilterFactory* factory) {
- factories_.push_back(factory);
- }
+ void AddFactory(FilterFactory* factory);
protected:
// Attempts to create a filter by walking down the list of filter factories.
- MediaFilter* Create(FilterType filter_type, const MediaFormat& media_format) {
- MediaFilter* filter = NULL;
- for (FactoryVector::iterator factory = factories_.begin();
- !filter && factory != factories_.end();
- ++factory) {
- filter = (*factory)->Create(filter_type, media_format);
- }
- return filter;
- }
+ MediaFilter* Create(FilterType filter_type, const MediaFormat& media_format);
private:
- ~FilterFactoryCollection() {}
+ ~FilterFactoryCollection();
typedef std::vector< scoped_refptr<FilterFactory> > FactoryVector;
FactoryVector factories_;
« no previous file with comments | « media/base/buffers.cc ('k') | media/base/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698