Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 3452030: FBTF: Moves code to the headers. (Closed)

Created:
10 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, fbarchard, Alpha Left Google, jam, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, scherkus (not reviewing)
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

FBTF: Moves code to the headers. One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file. (Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.) BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -72 lines) Patch
M app/active_window_watcher_x.h View 1 chunk +1 line, -0 lines 0 comments Download
M app/active_window_watcher_x.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M app/resource_bundle.h View 1 chunk +1 line, -0 lines 0 comments Download
M app/resource_bundle.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M app/sql/connection.h View 2 chunks +3 lines, -1 line 0 comments Download
M app/sql/connection.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M app/text_elider.h View 1 chunk +2 lines, -1 line 0 comments Download
M app/text_elider.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M base/histogram.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/histogram.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M base/message_loop_proxy.h View 1 chunk +3 lines, -4 lines 0 comments Download
A base/message_loop_proxy.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M base/message_pump.h View 1 chunk +2 lines, -1 line 0 comments Download
A base/message_pump.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M base/ref_counted_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/ref_counted_memory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M base/tracked_objects.h View 3 chunks +4 lines, -1 line 0 comments Download
M base/tracked_objects.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M base/waitable_event.h View 2 chunks +3 lines, -4 lines 0 comments Download
M base/waitable_event_posix.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/message_router.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/message_router.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/buffers.h View 1 chunk +2 lines, -4 lines 0 comments Download
M media/base/buffers.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M media/base/factory.h View 1 chunk +6 lines, -15 lines 0 comments Download
A media/base/factory.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M media/base/filters.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/filters.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/host_resolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/host_resolver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/base/x509_cert_types.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/block_files.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/block_files.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/disk_cache/in_flight_io.h View 3 chunks +4 lines, -7 lines 0 comments Download
M net/disk_cache/in_flight_io.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M net/disk_cache/rankings.h View 1 chunk +4 lines, -10 lines 0 comments Download
M net/disk_cache/rankings.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/disk_cache/trace.h View 1 chunk +2 lines, -7 lines 0 comments Download
M net/disk_cache/trace.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/http_util.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_util.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/spdy/spdy_settings_storage.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_settings_storage.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M skia/ext/convolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/convolver.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/pepper_resource.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_resource_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/pepper_resource_tracker.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
10 years, 2 months ago (2010-09-28 17:21:28 UTC) #1
Lei Zhang
10 years, 2 months ago (2010-09-28 22:23:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698