Issue 3452029: Corresponding trunk rename for pdf pref name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3452029: Corresponding trunk rename for pdf pref name. (Closed)

Created:
10 years, 2 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
laforge

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Corresponding trunk rename for pdf pref name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60707

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/pref_names.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

laforge

10 years, 2 months ago (2010-09-27 21:12:38 UTC) #2

LGTM

On Mon, Sep 27, 2010 at 2:08 PM, <jam@chromium.org> wrote:

> Reviewers: laforge,
>
> Description:
> Corresponding trunk rename for pdf pref name.
>
> Please review this at http://codereview.chromium.org/3452029/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/common/pref_names.cc
>
>
> Index: chrome/common/pref_names.cc
> ===================================================================
> --- chrome/common/pref_names.cc (revision 60371)
> +++ chrome/common/pref_names.cc (working copy)
> @@ -453,7 +453,7 @@
>
>  // When first shipped, the pdf plugin will be disabled by default.  When
> we
>  // enable it by default, we'll want to do so only once.
> -const char kPluginsEnabledInternalPDF[] = "plugins.enabled_internal_pdf";
> +const char kPluginsEnabledInternalPDF[] = "plugins.enabled_internal_pdf2";
>
>  // Boolean that indicates whether we should check if we are the default
> browser
>  // on start-up.
>
>
>

Expand Messages | Collapse Messages