Fix a memory leak in ExtensionMessageService.

chrome/browser/extensions/extension_message_service.h

Index: chrome/browser/extensions/extension_message_service.h
diff --git a/chrome/browser/extensions/extension_message_service.h b/chrome/browser/extensions/extension_message_service.h
index 0164cd225d977456f9c0953b023d070d88dc9394..cf52b65c3a206e3104c0f3e640d23e573cd34f12 100644
--- a/chrome/browser/extensions/extension_message_service.h
+++ b/chrome/browser/extensions/extension_message_service.h
@@ -9,7 +9,6 @@
 #include <set>
 #include <string>
 
-#include "base/linked_ptr.h"
 #include "base/lock.h"
 #include "base/ref_counted.h"
 #include "chrome/common/notification_registrar.h"
@@ -130,7 +129,7 @@ class ExtensionMessageService
 
  private:
   // A map of channel ID to its channel object.
-  typedef std::map<int, linked_ptr<MessageChannel> > MessageChannelMap;
+  typedef std::map<int, MessageChannel*> MessageChannelMap;

[Erik does not do reviews, 2009/11/04 17:00:33]

I think I'm missing something about the change away from linked_ptr.  Isn't this
equivalent to the old code (but less automatic)?

[Matt Perry, 2009/11/04 18:47:47]

Yes, theoretically. This is the "grasping at straws" part. I'm testing if
there's something about my usage of linked_ptr that may have caused a double
free. I couldn't find anything else in this file that was suspect. Json parsing
and serialization held up to fuzzing under purify.

 
   // Allocates a pair of port ids.
   // NOTE: this can be called from any thread.