Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 345057: EN, mf, DO YOU SPEAK IT? (Closed)

Created:
11 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org
Visibility:
Public.

Description

EN, mf, DO YOU SPEAK IT? No more symbolic links in the .app. Except for the ones that codesign adds. The en_US.lproj directory should not exist, there should be only en.lproj. Formerly, there was a symbolic link from en.lproj to en_US.lproj. BUG=25578, 19165 TEST= - find C.app -name en_US.lproj should return nothing. - find C.app -name en.lproj should show en.lproj in C.app, C F.framework, and C H.app. - find C.app -type l should return nothing, however, on a signed build, it will still show symbolic links for CodeResources. - Say "What" again. Say "What" again. I dare you. I double-dare you. - With English or U.S. English as the top or only choices in the International (10.5) or Language & Text (10.6) system preference pane's Language tab, the localized language should be English. - In this configuration, the Accept-Language header field should be "en-US,en;q=0.8". See http://whatsmyuseragent.com/ and look for HTTP_ACCEPT_LANGUAGE. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30955

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -52 lines) Patch
M chrome/app/app-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/framework-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/helper-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 7 chunks +39 lines, -13 lines 0 comments Download
M chrome/tools/build/apply_locales.py View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/tools/build/mac/symlink_lprojs View 1 1 chunk +0 lines, -28 lines 0 comments Download
A chrome/tools/build/mac/transition_lprojs View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/tools/mac_helpers/infoplist_strings_util.mm View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
"What" ain't no country I ever heard of. They speak en in What?
11 years, 1 month ago (2009-11-04 02:31:42 UTC) #1
TVL
11 years, 1 month ago (2009-11-04 14:06:08 UTC) #2
nice!

lgtm

Powered by Google App Engine
This is Rietveld 408576698