Issue 345033: Improve memwatch tool....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345033: Improve memwatch tool.... (Closed)

Created:
11 years, 1 month ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Improve memwatch tool. I removed a leak of "stack" objects, and made them a little more lightweight by removing an unused member. This change is only part of an option for chrome, that is not currently linked in during any tests. It can only currently be used under XP, so build-bot tests are not currently appropriate. r=mbelshe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30672

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -28 lines)			Patch
	M	tools/memory_watcher/call_stack.h	View	1	2 chunks	+6 lines, -14 lines	0 comments	Download
	M	tools/memory_watcher/memory_watcher.cc	View	1	3 chunks	+18 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

11 years, 1 month ago (2009-10-31 08:19:16 UTC) #2

lgtm

http://codereview.chromium.org/345033/diff/1/2
File tools/memory_watcher/call_stack.h (right):

http://codereview.chromium.org/345033/diff/1/2#newcode90
Line 90: explicit AllocationStack(int32 alloc_size)
looks like the argument alloc_size is now ignored?

http://codereview.chromium.org/345033/diff/1/3
File tools/memory_watcher/memory_watcher.cc (right):

http://codereview.chromium.org/345033/diff/1/3#newcode156
Line 156: // See if our |StackTracker| is also using |stack|.
what do the pipes |StackTracker| and |stack| mean in this context?  I thought
those were for documenting arguments in method calls?

Expand Messages | Collapse Messages