Issue 345032: Updates CFInstall.js to:...

Issue 345032: Updates CFInstall.js to:... (Closed)

Created:
11 years, 1 month ago by slightlyoff

Modified:
9 years, 7 months ago

Reviewers:
arv1, amit, arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Updates CFInstall.js to: * provide a new 'overlay' prompt mode that includes a "close" button with a cookie that respects the user preference for any originating site * handle requesting the install UI from a host page loaded from a file:// URL * expands UA detection to stop taunting Win2K (and below) users with visions of WebKit goodness * preserves full compat with previous version BUG=23057, 22738, 23132 TEST=see new test files in this change or build chrome_frame_tests and run with: chrome_frame_tests.exe --gtest_filter=*CFInstall* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31539

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 21

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+460 lines, -54 lines)			Patch
M	chrome_frame/CFInstall.js	View	1 2 3 4 5 6 7	7 chunks	+179 lines, -53 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_unittests.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	chrome_frame/test/data/CFInstall_basic.html	View	3 4 5 6	1 chunk	+41 lines, -0 lines	0 comments	Download
A	chrome_frame/test/data/CFInstall_dismiss.html	View	3 4 5 6	1 chunk	+53 lines, -0 lines	0 comments	Download
A	chrome_frame/test/data/CFInstall_overlay.html	View	3 4 5 6	1 chunk	+67 lines, -0 lines	0 comments	Download
A	chrome_frame/test/data/CFInstall_place.html	View	3 4 5 6	1 chunk	+74 lines, -0 lines	0 comments	Download
M	chrome_frame/test/data/chrome_frame_tester_helpers.js	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome_frame/test/http_server.cc	View	3	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv1

lgtm - only nits http://codereview.chromium.org/345032/diff/7003/9003 File chrome_frame/CFInstall.js (right): http://codereview.chromium.org/345032/diff/7003/9003#newcode131 Line 131: '-ms-filter:"progid:DXImageTransform.Microsoft.Alpha(Opacity=50)";' + long line ...

11 years, 1 month ago (2009-11-10 01:51:46 UTC) #2

slightlyoff

http://codereview.chromium.org/345032/diff/7003/9003 File chrome_frame/CFInstall.js (right): http://codereview.chromium.org/345032/diff/7003/9003#newcode131 Line 131: '-ms-filter:"progid:DXImageTransform.Microsoft.Alpha(Opacity=50)";' + On 2009/11/10 01:51:46, arv1 wrote: > ...

11 years, 1 month ago (2009-11-10 02:25:19 UTC) #3

lgtm

Expand Messages | Collapse Messages