Issue 345031: Destroy the TaskManagerGtk singleton instance when its window is destroyed, o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345031: Destroy the TaskManagerGtk singleton instance when its window is destroyed, o... (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Destroy the TaskManagerGtk singleton instance when its window is destroyed, otherwise its treeview will still be getting notifications and trying to manipulate the destroyed treeview. BUG=none TEST=Install an extension, open the task manager, and quit the browser should not result in a GTK error.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	chrome/browser/gtk/task_manager_gtk.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/task_manager_gtk.cc	View		4 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Why did OnDestroy hate me? Because it doesn't take a response_id. Sigh.

11 years, 1 month ago (2009-10-31 02:37:32 UTC) #1

lgtm

Expand Messages | Collapse Messages