Issue 345028: Fix several MAJOR crashers in Chrome+LocalStorage/Extensions. Need to explic...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345028: Fix several MAJOR crashers in Chrome+LocalStorage/Extensions. Need to explic... (Closed)

Created:
11 years, 1 month ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix several MAJOR crashers in Chrome+LocalStorage/Extensions. Need to explicitly call Stop() in destructor (before the vtable is torn down) since we override CleanUp(). Filed bug to make this impossible in the future: http://code.google.com/p/chromium/issues/detail?id=26365 TEST=DOMStorageTests UI tests don't fail. BUG=25413, 25746 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30638

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/in_process_webkit/webkit_thread.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM