Issue 345025: Set STATE_CLOSE when error occured.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345025: Set STATE_CLOSE when error occured. (Closed)

Created:
11 years, 1 month ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
tyoshino (SeeGerritForStatus), Yuta Kitamura, Yuzo

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Set STATE_CLOSE when error occured. Finish() when entered bad state. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30569

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
	M	net/socket_stream/socket_stream.cc	View		9 chunks	+22 lines, -5 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

11 years, 1 month ago (2009-11-02 02:18:27 UTC) #4

LGTM

Sorry for delay. Please try to address my comments in the next CL. Thanks,

http://codereview.chromium.org/345025/diff/1/2
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/345025/diff/1/2#newcode639
Line 639: DidEstablishConnection();
result = DidEstablishConnection ?

http://codereview.chromium.org/345025/diff/1/2#newcode707
Line 707: }
Here, we should do the same as Read?
if (result != 0 && result != ERR_IO_PENDING) {
  next_state_ = STATE_CLOSE;
  return result;
}

Expand Messages | Collapse Messages