Issue 345024: Unflaky tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345024: Unflaky tests. (Closed)

Created:
11 years, 1 month ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Unflaky tests. Since bug 24721 is fixed, these might work again. They don't show up on the flakiness dashboard, suggesting that they behaved for a while. BUG=24632, 24889 TEST=Tests not super flaky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30532

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/download/download_uitest.cc	View		2 chunks	+2 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 1 month ago (2009-10-29 23:17:47 UTC) #2

lgtm with nit

http://codereview.chromium.org/345024/diff/1/2
File chrome/browser/download/download_uitest.cc (right):

http://codereview.chromium.org/345024/diff/1/2#newcode179
Line 179: // This test is flaky. See bug 24889.
remove the comment?

Expand Messages | Collapse Messages