Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3308)

Unified Diff: chrome/installer/util/browser_distribution.cc

Issue 345021: Continue to remove CHROME_FRAME_BUILD define from code that goes into chrome.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.cc
===================================================================
--- chrome/installer/util/browser_distribution.cc (revision 30960)
+++ chrome/installer/util/browser_distribution.cc (working copy)
@@ -9,20 +9,32 @@
#include "chrome/installer/util/browser_distribution.h"
+#include "base/command_line.h"
#include "base/registry.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/env_vars.h"
+#include "chrome/installer/util/chrome_frame_distribution.h"
#include "chrome/installer/util/google_chrome_distribution.h"
-#include "chrome/installer/util/chrome_frame_distribution.h"
+#include "chrome/installer/util/install_util.h"
BrowserDistribution* BrowserDistribution::GetDistribution() {
+ return GetDistribution(InstallUtil::IsChromeFrameProcess());
+}
+
+BrowserDistribution* BrowserDistribution::GetDistribution(bool chrome_frame) {
static BrowserDistribution* dist = NULL;
if (dist == NULL) {
-#if defined(CHROME_FRAME_BUILD)
- dist = new ChromeFrameDistribution();
-#elif defined(GOOGLE_CHROME_BUILD)
- dist = new GoogleChromeDistribution();
+ if (chrome_frame) {
+ // TODO(robertshield): Make one of these for Google Chrome vs
+ // non Google Chrome builds?
+ dist = new ChromeFrameDistribution();
+ } else {
+#if defined(GOOGLE_CHROME_BUILD)
+ dist = new GoogleChromeDistribution();
#else
- dist = new BrowserDistribution();
+ dist = new BrowserDistribution();
#endif
+ }
}
return dist;
}

Powered by Google App Engine
This is Rietveld 408576698