Modify rebaseline tool to work with git and add vista rebaseline...

Modify rebaseline tool to work with git and add rebaseline for vista

R=ojan
BUG=25858
TEST=rebaseline tool


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30361

[ojan, 2009-10-28 17:13:09]

LGTM

Is there any documentation for using this tool? If so, it might be worth
updating it to say that it works with git, but that you need to manually git add
all the files it adds.

[tony, 2009-10-28 17:16:39]

http://codereview.chromium.org/345008/diff/1/2
File webkit/tools/layout_tests/rebaseline.py (right):

http://codereview.chromium.org/345008/diff/1/2#newcode39
Line 39: (REPO_SVN, REPO_GIT) = range(2)
Nit: You don't need () on the left hand side of the assignment.
Can we use REPO_UNKNOWN rather than REPO_GIT?  You don't actually check to see
if it's git or run any git commands.

http://codereview.chromium.org/345008/diff/1/2#newcode219
Line 219: def _GetRepoType(self):
Nit: Missing doc string.

http://codereview.chromium.org/345008/diff/1/2#newcode221
Line 221: if (not output) or (output.lower().rstrip().endswith(
I'm not certain that this works for localized versions of svn.  Can you look at
the return code or something?

[Victor Wang, 2009-10-28 18:01:15]

On 2009/10/28 17:13:09, ojan wrote:
> LGTM
> 
> Is there any documentation for using this tool? If so, it might be worth
> updating it to say that it works with git, but that you need to manually git
add
> all the files it adds.

yes. will do once this is committed.

[Victor Wang, 2009-10-28 18:01:57]

On 2009/10/28 17:16:39, tony wrote:
> http://codereview.chromium.org/345008/diff/1/2
> File webkit/tools/layout_tests/rebaseline.py (right):
> 
> http://codereview.chromium.org/345008/diff/1/2#newcode39
> Line 39: (REPO_SVN, REPO_GIT) = range(2)
> Nit: You don't need () on the left hand side of the assignment.
> Can we use REPO_UNKNOWN rather than REPO_GIT?  You don't actually check to see
> if it's git or run any git commands.
good suggestion. done.

> 
> http://codereview.chromium.org/345008/diff/1/2#newcode219
> Line 219: def _GetRepoType(self):
> Nit: Missing doc string.
done

> 
> http://codereview.chromium.org/345008/diff/1/2#newcode221
> Line 221: if (not output) or (output.lower().rstrip().endswith(
> I'm not certain that this works for localized versions of svn.  Can you look
at
> the return code or something?
done

[tony, 2009-10-28 18:04:01]

LGTM, thanks for doing this!