Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Side by Side Diff: test/mjsunit/regress/regress-485.js

Issue 345007: Issue 485: Fix leak of builtins object through call and apply functions. (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // See: http://code.google.com/p/v8/issues/detail?id=485
29
30 // Ensure that we don't expose the builtins object when calling
31 // builtin functions that use or return "this".
32
33 var global = this;
34 var global2 = (function(){return this;})();
35 assertEquals(global, global2, "direct call to local function returns global");
36
37 var builtin = Object.prototype.valueOf; // Builtin function that returns this.
38
39 assertEquals(global, builtin(), "Direct call to builtin");
40
41 assertEquals(global, builtin.call(), "call() to builtin");
42 assertEquals(global, builtin.call(null), "call(null) to builtin");
43 assertEquals(global, builtin.call(undefined), "call(undefined) to builtin");
44
45 assertEquals(global, builtin.apply(), "apply() to builtin");
46 assertEquals(global, builtin.apply(null), "apply(null) to builtin");
47 assertEquals(global, builtin.apply(undefined), "apply(undefined) to builtin");
48
49 assertEquals(global, builtin.call.call(builtin), "call.call() to builtin");
50 assertEquals(global, builtin.call.apply(builtin), "call.apply() to builtin");
51 assertEquals(global, builtin.apply.call(builtin), "apply.call() to builtin");
52 assertEquals(global, builtin.apply.apply(builtin), "apply.apply() to builtin");
53
54
55 // Builtin that depends on value of this to compute result.
56 var builtin2 = Object.prototype.toString;
57
58 // Global object has class "Object" according to Object.prototype.toString.
59 // Builtins object displays as "[object builtins]".
60 assertTrue("[object builtins]" != builtin2(), "Direct call to toString");
61 assertTrue("[object builtins]" != builtin2.call(), "call() to toString");
62 assertTrue("[object builtins]" != builtin2.apply(), "call() to toString");
63 assertTrue("[object builtins]" != builtin2.call.call(builtin2),
64 "call.call() to toString");
OLDNEW
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698