Issue 345007: Issue 485: Fix leak of builtins object through call and apply functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345007: Issue 485: Fix leak of builtins object through call and apply functions. (Closed)

Created:
11 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Issue 485: Fix leak of builtins object through call and apply functions.

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -0 lines)			Patch
M	src/arm/builtins-arm.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-485.js	View	1 chunk	+64 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Lasse Reichstein

Still waiting for performance data to see if it's viable.

11 years, 1 month ago (2009-10-28 11:44:40 UTC) #1

Mads Ager (chromium)

11 years, 1 month ago (2009-10-28 11:59:06 UTC) #2

LGTM, I would not expect this to be a problem for performance, but let's wait
for the data.